github-actions[bot] commented on code in PR #33890:
URL: https://github.com/apache/doris/pull/33890#discussion_r1590514076
##########
be/src/vec/columns/column_object.cpp:
##########
@@ -207,8 +266,10 @@ class FieldVisitorToScalarType : public
StaticVisitor<size_t> {
type_indexes.insert(TypeId<NearestFieldType<T>>::value);
return 0;
}
- void get_scalar_type(DataTypePtr* type) const {
- get_least_supertype<LeastSupertypeOnError::Jsonb>(type_indexes, type);
+ void get_scalar_type(TypeIndex* type) const {
Review Comment:
warning: method 'get_scalar_type' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void get_scalar_type(TypeIndex* type) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
