wangbo commented on a change in pull request #7613: URL: https://github.com/apache/incubator-doris/pull/7613#discussion_r781878190
########## File path: be/src/vec/columns/column.h ########## @@ -411,10 +413,15 @@ class IColumn : public COW<IColumn> { // only used in ColumnNullable replace_column_data virtual void replace_column_data_default(size_t self_row = 0) = 0; - bool is_date_type() { return is_date; } + virtual bool is_date_type() { return is_date; } Review comment: This is a temporary implementation, this method would be removed later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org