HappenLee commented on code in PR #34042:
URL: https://github.com/apache/doris/pull/34042#discussion_r1590005743


##########
be/src/vec/data_types/serde/data_type_ipv4_serde.cpp:
##########
@@ -108,5 +109,29 @@ Status DataTypeIPv4SerDe::read_column_from_pb(IColumn& 
column, const PValues& ar
     }
     return Status::OK();
 }
+
+void DataTypeIPv4SerDe::write_column_to_arrow(const IColumn& column, const 
NullMap* null_map,
+                                              arrow::ArrayBuilder* 
array_builder, int start,
+                                              int end, const cctz::time_zone& 
ctz) const {
+    const auto& col_data = static_cast<const ColumnIPv4&>(column).get_data();

Review Comment:
   use assert_cast



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to