englefly commented on code in PR #34263:
URL: https://github.com/apache/doris/pull/34263#discussion_r1582736545


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/stats/StatsCalculator.java:
##########
@@ -807,13 +810,21 @@ private Statistics computeCatalogRelation(CatalogRelation 
catalogRelation) {
                 hasUnknownCol = true;
             }
             if (ConnectContext.get() != null && 
ConnectContext.get().getSessionVariable().enableStats) {
-                if (deltaRowCount > 0) {
-                    // clear min-max to avoid error estimation
-                    // for example, after yesterday data loaded, user send 
query about yesterday immediately.
-                    // since yesterday data are not analyzed, the max date is 
before yesterday, and hence optimizer
-                    // estimates the filter result is zero
-                    
colStatsBuilder.setMinExpr(null).setMinValue(Double.NEGATIVE_INFINITY)
+                if (deltaRowCount > 0 && isOlapTable) {

Review Comment:
   since the meaning of tableMeta.updatedRows changed, "deltaRowCount" variable 
name is not proper anymore



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to