morrySnow commented on code in PR #34287:
URL: https://github.com/apache/doris/pull/34287#discussion_r1582696745


##########
fe/fe-core/src/main/java/org/apache/doris/backup/RestoreJob.java:
##########
@@ -808,7 +808,7 @@ private void checkAndPrepareMeta() {
 
             // generate create replica task for all restored tables
             for (Table restoreTbl : restoredTbls) {
-                if (restoreTbl.getType() == TableType.OLAP) {

Review Comment:
   so async mv support backup and restore?



##########
fe/fe-core/src/main/java/org/apache/doris/catalog/CatalogRecycleBin.java:
##########
@@ -112,7 +112,7 @@ public synchronized boolean 
allTabletsInRecycledStatus(List<Long> backendTabletI
     }
 
     private void addRecycledTabletsForTable(Set<Long> recycledTabletSet, Table 
table) {
-        if (table.getType() == TableType.OLAP) {

Review Comment:
   could we restore async mv from recycle bin? or we just mv it into recycle 
bin when we drop it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to