924060929 commented on a change in pull request #7645:
URL: https://github.com/apache/incubator-doris/pull/7645#discussion_r780131027
##########
File path: fe/fe-core/src/test/java/org/apache/doris/planner/QueryPlanTest.java
##########
@@ -1366,23 +1366,15 @@ public void testRuntimeFilterMode() throws Exception {
queryStr = "explain select * from jointest t2, jointest t1 where t1.k1
<=> t2.k1";
Deencapsulation.setField(connectContext.getSessionVariable(),
"runtimeFilterMode", "LOCAL");
- Deencapsulation.setField(connectContext.getSessionVariable(),
"runtimeFilterType", 7);
+ Deencapsulation.setField(connectContext.getSessionVariable(),
"runtimeFilterType", 15);
Review comment:
> Can I change the type? Such as 8
You can.
origin test, 7 means: IN,BLOOM_FILTER,MIN_MAX
new test, 15 means: IN,BLOOM_FILTER,MIN_MAX,IN_OR_BLOOM_FILTER
Already test `8` in other test
##########
File path: fe/fe-core/src/test/java/org/apache/doris/planner/QueryPlanTest.java
##########
@@ -1429,6 +1421,64 @@ public void testRuntimeFilterType() throws Exception {
explainString = UtFrameUtils.getSQLPlanOrErrorMsg(connectContext,
queryStr);
Assert.assertTrue(explainString.contains("runtime filters: RF000[in]
<- `t1`.`k1`, RF001[bloom] <- `t1`.`k1`, RF002[min_max] <- `t1`.`k1`"));
Assert.assertTrue(explainString.contains("runtime filters: RF000[in]
-> `t2`.`k1`, RF001[bloom] -> `t2`.`k1`, RF002[min_max] -> `t2`.`k1`"));
+
+ Deencapsulation.setField(connectContext.getSessionVariable(),
"runtimeFilterType", 8);
+ explainString = UtFrameUtils.getSQLPlanOrErrorMsg(connectContext,
queryStr);
+ Assert.assertTrue(explainString.contains("runtime filters:
RF000[in_or_bloom] <- `t1`.`k1`"));
+ Assert.assertTrue(explainString.contains("runtime filters:
RF000[in_or_bloom] -> `t2`.`k1`"));
+
+ Deencapsulation.setField(connectContext.getSessionVariable(),
"runtimeFilterType", 9);
Review comment:
Okey, I will add some note to the doc
##########
File path: fe/fe-core/src/test/java/org/apache/doris/planner/QueryPlanTest.java
##########
@@ -1429,6 +1421,64 @@ public void testRuntimeFilterType() throws Exception {
explainString = UtFrameUtils.getSQLPlanOrErrorMsg(connectContext,
queryStr);
Assert.assertTrue(explainString.contains("runtime filters: RF000[in]
<- `t1`.`k1`, RF001[bloom] <- `t1`.`k1`, RF002[min_max] <- `t1`.`k1`"));
Assert.assertTrue(explainString.contains("runtime filters: RF000[in]
-> `t2`.`k1`, RF001[bloom] -> `t2`.`k1`, RF002[min_max] -> `t2`.`k1`"));
+
+ Deencapsulation.setField(connectContext.getSessionVariable(),
"runtimeFilterType", 8);
+ explainString = UtFrameUtils.getSQLPlanOrErrorMsg(connectContext,
queryStr);
+ Assert.assertTrue(explainString.contains("runtime filters:
RF000[in_or_bloom] <- `t1`.`k1`"));
+ Assert.assertTrue(explainString.contains("runtime filters:
RF000[in_or_bloom] -> `t2`.`k1`"));
+
+ Deencapsulation.setField(connectContext.getSessionVariable(),
"runtimeFilterType", 9);
Review comment:
add add the comment to this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
