XieJiann commented on code in PR #34171:
URL: https://github.com/apache/doris/pull/34171#discussion_r1582003157
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Lambda.java:
##########
@@ -41,21 +41,22 @@ public class Lambda extends Expression {
private final List<String> argumentNames;
+ private final Expression lambdaFunctionBody;
+
/**
* constructor
*/
public Lambda(List<String> argumentNames, Expression lambdaFunction) {
- this(argumentNames, ImmutableList.of(lambdaFunction));
- }
-
- public Lambda(List<String> argumentNames, Expression lambdaFunction,
List<ArrayItemReference> arguments) {
- this(argumentNames,
ImmutableList.<Expression>builder().add(lambdaFunction).addAll(arguments).build());
+ this.argumentNames = ImmutableList.copyOf(Objects.requireNonNull(
+ argumentNames, "argumentNames should not null"));
Review Comment:
Call a unified constructor in other constructors instead of initializing
member variables in each constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
