kaka11chen commented on code in PR #33937:
URL: https://github.com/apache/doris/pull/33937#discussion_r1581996188


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSTransaction.java:
##########
@@ -1194,6 +1285,11 @@ public void prepareInsertExistPartition(PartitionAndMore 
partitionAndMore) {
                         writePath,
                         targetPath,
                         partitionAndMore.getFileNames());
+            } else {
+                if 
(!partitionAndMore.hivePartitionUpdate.s3_mpu_pending_uploads.isEmpty()) {
+                    s3Commit(fileSystemExecutor, asyncFileSystemTaskFutures, 
fileSystemTaskCancelled,

Review Comment:
   ok, use one thread pool per catalog.



##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSTransaction.java:
##########
@@ -1194,6 +1285,11 @@ public void prepareInsertExistPartition(PartitionAndMore 
partitionAndMore) {
                         writePath,
                         targetPath,
                         partitionAndMore.getFileNames());
+            } else {
+                if 
(!partitionAndMore.hivePartitionUpdate.s3_mpu_pending_uploads.isEmpty()) {
+                    s3Commit(fileSystemExecutor, asyncFileSystemTaskFutures, 
fileSystemTaskCancelled,

Review Comment:
   ok, will use one thread pool per catalog.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to