morningman commented on a change in pull request #7600:
URL: https://github.com/apache/incubator-doris/pull/7600#discussion_r779633511
##########
File path: be/src/vec/core/block.h
##########
@@ -129,6 +129,7 @@ class Block {
Names get_names() const;
DataTypes get_data_types() const;
+ DataTypePtr get_data_type(size_t index) const { return index < data.size()
? data[index].type : nullptr; }
Review comment:
Better to use `CHECK(index < data.size())`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
