SWJTU-ZhangLei commented on code in PR #34068: URL: https://github.com/apache/doris/pull/34068#discussion_r1578774764
########## fe/fe-core/src/main/java/org/apache/doris/analysis/ShowDataStmt.java: ########## @@ -101,15 +108,78 @@ public class ShowDataStmt extends ShowStmt { private List<OrderByElement> orderByElements; private List<OrderByPair> orderByPairs; - public ShowDataStmt(TableName tableName, List<OrderByElement> orderByElements) { + private final Map<String, String> properties; + + private static final String WAREHOUSE = "entire_warehouse"; + private static final String DB_LIST = "db_names"; + + public ShowDataStmt(TableName tableName, List<OrderByElement> orderByElements, Map<String, String> properties) { this.tableName = tableName; this.totalRows = Lists.newArrayList(); this.orderByElements = orderByElements; + this.properties = properties; } @Override public void analyze(Analyzer analyzer) throws UserException { super.analyze(analyzer); + if (properties != null) { Review Comment: > consider using a separate mothod resolved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org