kobe6th commented on code in PR #34057:
URL: https://github.com/apache/doris/pull/34057#discussion_r1577846839
##########
be/src/io/fs/s3_file_system.cpp:
##########
@@ -134,8 +139,7 @@ Status S3ClientHolder::reset(const S3ClientConf& conf) {
{
std::lock_guard lock(_mtx);
_client = std::move(client);
- _conf.ak = conf.ak;
- _conf.sk = conf.sk;
+ _conf = std::move(reset_conf);
Review Comment:
是等价的，目前这样写可以少2行代码。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
