github-actions[bot] commented on code in PR #32620: URL: https://github.com/apache/doris/pull/32620#discussion_r1577667084
########## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ########## @@ -815,6 +835,17 @@ bool SegmentIterator::_can_filter_by_preds_except_leafnode_of_andnode() { return true; } +bool SegmentIterator::_check_apply_by_inverted_index(ColumnId col_id) { Review Comment: warning: method '_check_apply_by_inverted_index' can be made static [readability-convert-member-functions-to-static] be/src/olap/rowset/segment_v2/segment_iterator.h:288: ```diff - bool _check_apply_by_inverted_index(ColumnId col_id); + static bool _check_apply_by_inverted_index(ColumnId col_id); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org