morningman commented on a change in pull request #7548:
URL: https://github.com/apache/incubator-doris/pull/7548#discussion_r777810849



##########
File path: extension/spark-doris-connector/build.sh
##########
@@ -25,23 +25,35 @@
 
 set -eo pipefail
 
-ROOT=`dirname "$0"`
-ROOT=`cd "$ROOT"; pwd`
+usage() {
+  echo "
+  Eg.
+    $0 spark_version scala_version

Review comment:
       list all 

##########
File path: extension/flink-doris-connector/build.sh
##########
@@ -25,23 +25,45 @@
 
 set -eo pipefail
 
-ROOT=`dirname "$0"`
-ROOT=`cd "$ROOT"; pwd`
+usage() {
+  echo "
+  Eg.
+    $0 flink_version scala_version

Review comment:
       How about list all ?
   ```
   sh build.sh 1.11.6 2.12
   sh build.sh 1.12.7 2.12
   sh build.sh 1.13.5 2.12
   ```
   
   So that we don't need to find the document each time we try to build.
   Same as Spark Connector
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to