github-actions[bot] commented on code in PR #33959: URL: https://github.com/apache/doris/pull/33959#discussion_r1575627693
########## be/src/io/hdfs_util.h: ########## @@ -73,17 +71,14 @@ class HdfsHandler { int64_t last_access_time() { return _last_access_time; } - void inc_ref() { - _ref_cnt++; - _last_access_time = std::chrono::duration_cast<std::chrono::milliseconds>( - std::chrono::system_clock::now().time_since_epoch()) - .count(); + void update_last_access_time() { Review Comment: warning: method 'update_last_access_time' can be made const [readability-make-member-function-const] ```suggestion void update_last_access_time() const { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org