Jibing-Li commented on code in PR #33836:
URL: https://github.com/apache/doris/pull/33836#discussion_r1575576413


##########
fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java:
##########
@@ -995,7 +996,7 @@ public int getExecTimeout() {
             // particular for insert stmt, we can expand other type of timeout 
in the same way
             return Math.max(sessionVariable.getInsertTimeoutS(), 
sessionVariable.getQueryTimeoutS());
         } else if (executor != null && executor.isAnalyzeStmt()) {
-            return sessionVariable.getAnalyzeTimeoutS();
+            return StatisticConstants.ANALYZE_TIMEOUT_IN_SEC;

Review Comment:
   AnalyzeStmt is the statement executed by mysql connection thread. Before, 
AnalyzeStmt was using analyze_timeout, but it brings the problem that 
AnalyzeStmt may be timeout but the internal analyze sql has not cancelled yet, 
in this case, the cancellation may fail. So here use a fixed timeout value for 
AnalyzeStmt and use analyze_timeout to control the analyze sql timeout. When 
analyze sql timeout, AnalyzeStmt will get an exception and return.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to