zhiqiang-hhhh commented on code in PR #33968: URL: https://github.com/apache/doris/pull/33968#discussion_r1574378047
########## be/src/vec/functions/function_ip.h: ########## @@ -771,7 +771,7 @@ class FunctionIPv4CIDRToRange : public IFunction { ColumnWithTypeAndName& cidr_column = block.get_by_position(arguments[1]); const ColumnPtr& ip_column_ptr = ip_column.column; - const ColumnPtr& cidr_column_ptr = cidr_column.column; + const auto& [cidr_column_ptr, col_const] = unpack_if_const(cidr_column.column); Review Comment: do same thing to ip_column, or query like `select id, ipv4_cidr_to_range("127.0.0.1", cidr) from test_ipv4_cidr_to_range order by id` will make be crash too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org