yiguolei commented on code in PR #33934:
URL: https://github.com/apache/doris/pull/33934#discussion_r1573838133
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -1957,13 +1957,12 @@ void SegmentIterator::_replace_version_col(size_t
num_rows) {
uint16_t SegmentIterator::_evaluate_vectorization_predicate(uint16_t*
sel_rowid_idx,
uint16_t
selected_size) {
SCOPED_RAW_TIMER(&_opts.stats->vec_cond_ns);
- if (_is_need_vec_eval) {
- _is_need_vec_eval = false;
- for (const auto& pred : _pre_eval_block_predicate) {
- _is_need_vec_eval |= (!pred->always_true());
- }
- }
- if (!_is_need_vec_eval) {
+ bool all_pred_always_true =
Review Comment:
不要这么写，这么写语义并不是很清楚。
比如_pre_eval_block_predicate 为空的时候，这个值是多少？ 先设置一个变量，然后再赋值。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
