yiguolei commented on code in PR #33900:
URL: https://github.com/apache/doris/pull/33900#discussion_r1572684222
##########
be/src/vec/spill/spill_stream_manager.cpp:
##########
@@ -266,6 +267,20 @@ void SpillStreamManager::gc(int64_t max_file_count) {
}
}
+void SpillStreamManager::cleanup_query(TUniqueId query_id) {
+ for (auto& [_, store] : _spill_store_map) {
+ std::string query_spill_dir =
Review Comment:
This should not be a sync api. Because this is called in ~QueryContext, it
may hang pipeline thread.
This API should be an async API, it only submit a task to spill thread pool.
And the io thread will delete these folder async.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
