github-actions[bot] commented on code in PR #33841:
URL: https://github.com/apache/doris/pull/33841#discussion_r1572222407
##########
be/src/util/block_compression.cpp:
##########
@@ -471,9 +487,15 @@
static Lz4HCBlockCompression s_instance;
return &s_instance;
}
- ~Lz4HCBlockCompression() { _ctx_pool.clear(); }
+ ~Lz4HCBlockCompression() {
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final'
[modernize-use-override]
```suggestion
~Lz4HCBlockCompression() override {
```
##########
be/src/util/block_compression.cpp:
##########
@@ -111,9 +111,15 @@ class Lz4BlockCompression : public BlockCompressionCodec {
static Lz4BlockCompression s_instance;
return &s_instance;
}
- ~Lz4BlockCompression() { _ctx_pool.clear(); }
+ ~Lz4BlockCompression() {
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final'
[modernize-use-override]
```suggestion
~Lz4BlockCompression() override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
