xinyiZzz commented on code in PR #33853: URL: https://github.com/apache/doris/pull/33853#discussion_r1572198318
########## be/src/common/stack_trace.cpp: ########## @@ -439,7 +439,8 @@ static StackTraceCache& cacheInstance() { static std::mutex stacktrace_cache_mutex; -std::string toStringCached(const StackTrace::FramePointers& pointers, size_t offset, size_t size) { +std::string toStringCached(const StackTrace::FramePointers& pointers, size_t offset, size_t size, Review Comment: i am 99.99% sure it's fine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org