github-actions[bot] commented on code in PR #33851:
URL: https://github.com/apache/doris/pull/33851#discussion_r1571954273
##########
be/test/olap/tablet_test.cpp:
##########
@@ -148,6 +148,20 @@ class TestTablet : public testing::Test {
pb1->set_tablet_schema(_tablet_meta->tablet_schema());
}
+ void init_rs_meta_resource(RowsetMetaSharedPtr& pb1, int64_t start,
int64_t end,
Review Comment:
warning: method 'init_rs_meta_resource' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void init_rs_meta_resource(RowsetMetaSharedPtr& pb1, int64_t
start, int64_t end,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
