zhannngchen commented on code in PR #33859:
URL: https://github.com/apache/doris/pull/33859#discussion_r1571695945
##########
be/src/cloud/cloud_full_compaction.cpp:
##########
@@ -295,7 +295,14 @@ void CloudFullCompaction::do_lease() {
}
}
-Status
CloudFullCompaction::_cloud_full_compaction_update_delete_bitmap(int64_t
initiator) {
+Status
CloudFullCompaction::_cloud_full_compaction_update_delete_bitmap_if_necessary(
+ int64_t initiator) {
+ if (_tablet->keys_type() != KeysType::UNIQUE_KEYS) {
Review Comment:
It would be more intuitive to put this judgment logic outside of the
function call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
