wuwenchi commented on code in PR #33798:
URL: https://github.com/apache/doris/pull/33798#discussion_r1568922425


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSTransaction.java:
##########
@@ -575,15 +582,18 @@ private DeleteRecursivelyResult 
doRecursiveDeleteFiles(Path directory, boolean d
         boolean allDescendentsDeleted = true;
         ImmutableList.Builder<String> notDeletedEligibleItems = 
ImmutableList.builder();
         for (RemoteFile file : allFiles) {
-            String fileName = file.getName();
-            if (!deleteIfExists(new Path(fileName))) {
+            if (file.getName().startsWith(queryId)) {

Review Comment:
   Since the files generated by be all start with `queryId`, it may be that 
`startsWith` is more appropriate than the `contain` check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to