HappenLee commented on code in PR #33595:
URL: https://github.com/apache/doris/pull/33595#discussion_r1568389564


##########
be/src/vec/functions/function_fake.h:
##########
@@ -63,4 +63,37 @@ class FunctionFake : public IFunction {
     }
 };
 
+struct UDTFImpl {
+    static DataTypePtr get_return_type_impl(const DataTypes& arguments) {
+        DCHECK(false) << "get_return_type_impl not supported";
+        return nullptr;
+    }
+    static std::string get_error_msg() { return "Fake function do not support 
execute"; }
+};
+
+class FakeJavaUDTF : public FunctionFake<UDTFImpl> {

Review Comment:
   seems useless in code. Why not use FunctionFake directly?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to