kaijchen commented on code in PR #32845: URL: https://github.com/apache/doris/pull/32845#discussion_r1568143895
########## fe/fe-core/src/main/java/org/apache/doris/analysis/NativeInsertStmt.java: ########## @@ -1023,13 +1023,16 @@ private DataSink createDataSink() throws AnalysisException { } if (targetTable instanceof OlapTable) { OlapTableSink sink; + final boolean enableSingleReplicaLoad = + analyzer.getContext().getSessionVariable().isEnableMemtableOnSinkNode() + ? false : analyzer.getContext().getSessionVariable().isEnableSingleReplicaInsert(); if (isGroupCommitStreamLoadSql) { sink = new GroupCommitBlockSink((OlapTable) targetTable, olapTuple, - targetPartitionIds, analyzer.getContext().getSessionVariable().isEnableSingleReplicaInsert(), + targetPartitionIds, enableSingleReplicaLoad, ConnectContext.get().getSessionVariable().getGroupCommit(), 0); } else { sink = new OlapTableSink((OlapTable) targetTable, olapTuple, targetPartitionIds, - analyzer.getContext().getSessionVariable().isEnableSingleReplicaInsert()); + enableSingleReplicaLoad); Review Comment: Currently there is no `single_replica_load` option in nereids. This PR is for fixing a problem. If there is a need, we can create a new PR for that feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org