github-actions[bot] commented on code in PR #33720: URL: https://github.com/apache/doris/pull/33720#discussion_r1567112329
########## be/src/vec/sink/writer/vfile_result_writer.h: ########## @@ -0,0 +1,143 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <gen_cpp/Types_types.h> +#include <stddef.h> +#include <stdint.h> + +#include <iosfwd> +#include <memory> +#include <string> +#include <vector> + +#include "common/status.h" +#include "io/fs/file_writer.h" +#include "runtime/descriptors.h" +#include "util/runtime_profile.h" +#include "vec/core/block.h" +#include "vec/runtime/vfile_format_transformer.h" +#include "vec/sink/writer/async_result_writer.h" + +namespace doris { +class BufferControlBlock; +class RuntimeState; + +namespace vectorized { +class VExprContext; +struct ResultFileOptions; +} // namespace vectorized +} // namespace doris + +namespace doris::vectorized { + +// write result to file +class VFileResultWriter final : public AsyncResultWriter { +public: + VFileResultWriter(const ResultFileOptions* file_option, + const TStorageBackendType::type storage_type, + const TUniqueId fragment_instance_id, + const VExprContextSPtrs& _output_vexpr_ctxs, BufferControlBlock* sinker, + Block* output_block, bool output_object_data, + const RowDescriptor& output_row_descriptor); + + VFileResultWriter(const TDataSink& t_sink, const VExprContextSPtrs& output_exprs); + + Status write(Block& block) override; + + Status close(Status exec_status) override; + + Status open(RuntimeState* state, RuntimeProfile* profile) override; + + // file result writer always return statistic result in one row + int64_t get_written_rows() const override { return 1; } Review Comment: warning: function 'get_written_rows' should be marked [[nodiscard]] [modernize-use-nodiscard] ```suggestion [[nodiscard]] int64_t get_written_rows() const override { return 1; } ``` ########## be/src/vec/sink/writer/vfile_result_writer.h: ########## @@ -0,0 +1,143 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <gen_cpp/Types_types.h> Review Comment: warning: 'gen_cpp/Types_types.h' file not found [clang-diagnostic-error] ```cpp #include <gen_cpp/Types_types.h> ^ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
