github-actions[bot] commented on code in PR #33663:
URL: https://github.com/apache/doris/pull/33663#discussion_r1567042979
##########
be/src/olap/rowset/segment_v2/column_writer.cpp:
##########
@@ -481,9 +482,40 @@ Status ScalarColumnWriter::init() {
}
if (_opts.need_inverted_index) {
- RETURN_IF_ERROR(InvertedIndexColumnWriter::create(get_field(),
&_inverted_index_builder,
-
_opts.inverted_index_file_writer,
-
_opts.inverted_index));
+ do {
+ DBUG_EXECUTE_IF("column_writer.init", {
+ class InvertedIndexColumnWriterEmptyImpl final : public
InvertedIndexColumnWriter {
+ public:
+ Status init() override { return Status::OK(); }
+ Status add_values(const std::string name, const void*
values,
Review Comment:
warning: method 'add_values' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status add_values(const std::string name, const
void* values,
```
<details>
<summary>Additional context</summary>
**be/src/util/debug_points.h:39:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
code;
\
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
