github-actions[bot] commented on code in PR #33689:
URL: https://github.com/apache/doris/pull/33689#discussion_r1566644693
##########
be/src/pipeline/exec/nested_loop_join_build_operator.cpp:
##########
@@ -53,6 +49,18 @@ Status NestedLoopJoinBuildSinkLocalState::init(RuntimeState*
state, LocalSinkSta
return Status::OK();
}
+Status NestedLoopJoinBuildSinkLocalState::open(RuntimeState* state) {
Review Comment:
warning: method 'open' can be made static
[readability-convert-member-functions-to-static]
be/src/pipeline/exec/nested_loop_join_build_operator.h:58:
```diff
- Status open(RuntimeState* state) override;
+ static Status open(RuntimeState* state) override;
```
##########
be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:
##########
@@ -52,15 +52,21 @@
NestedLoopJoinProbeLocalState::NestedLoopJoinProbeLocalState(RuntimeState* state
Status NestedLoopJoinProbeLocalState::init(RuntimeState* state,
LocalStateInfo& info) {
RETURN_IF_ERROR(JoinProbeLocalState::init(state, info));
SCOPED_TIMER(exec_time_counter());
+ SCOPED_TIMER(_init_timer);
+ _loop_join_timer = ADD_TIMER(profile(), "LoopGenerateJoin");
+ return Status::OK();
+}
+
+Status NestedLoopJoinProbeLocalState::open(RuntimeState* state) {
Review Comment:
warning: method 'open' can be made static
[readability-convert-member-functions-to-static]
be/src/pipeline/exec/nested_loop_join_probe_operator.h:68:
```diff
- Status open(RuntimeState* state) override;
+ static Status open(RuntimeState* state) override;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
