github-actions[bot] commented on code in PR #33496:
URL: https://github.com/apache/doris/pull/33496#discussion_r1565957282


##########
be/src/pipeline/exec/scan_operator.cpp:
##########
@@ -164,7 +161,7 @@ Status ScanLocalState<Derived>::open(RuntimeState* state) {
 }
 
 template <typename Derived>
-Status ScanLocalState<Derived>::_normalize_conjuncts() {
+Status ScanLocalState<Derived>::_normalize_conjuncts(RuntimeState* state) {

Review Comment:
   warning: function '_normalize_conjuncts' exceeds recommended size/complexity 
thresholds [readability-function-size]
   ```cpp
   Status ScanLocalState<Derived>::_normalize_conjuncts(RuntimeState* state) {
                                   ^
   ```
   <details>
   <summary>Additional context</summary>
   
   **be/src/pipeline/exec/scan_operator.cpp:163:** 98 lines including 
whitespace and comments (threshold 80)
   ```cpp
   Status ScanLocalState<Derived>::_normalize_conjuncts(RuntimeState* state) {
                                   ^
   ```
   
   </details>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to