github-actions[bot] commented on code in PR #33396:
URL: https://github.com/apache/doris/pull/33396#discussion_r1564032406
##########
be/src/vec/common/pod_array.h:
##########
@@ -598,28 +599,29 @@ class PODArray : public PODArrayBase<sizeof(T),
initial_bytes, TAllocator, pad_r
void assign(const PODArray& from) { assign(from.begin(), from.end()); }
- bool operator==(const PODArray& other) const {
- if (this->size() != other.size()) return false;
+ bool operator==(const PODArray& rhs) const {
+ if (this->size() != rhs.size()) return false;
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (this->size() != rhs.size()) { return false;
}
```
##########
be/src/vec/common/pod_array.h:
##########
@@ -598,28 +599,29 @@
void assign(const PODArray& from) { assign(from.begin(), from.end()); }
- bool operator==(const PODArray& other) const {
- if (this->size() != other.size()) return false;
+ bool operator==(const PODArray& rhs) const {
+ if (this->size() != rhs.size()) return false;
- const_iterator this_it = begin();
- const_iterator that_it = other.begin();
+ const_iterator lhs_it = begin();
+ const_iterator rhs_it = rhs.begin();
- while (this_it != end()) {
- if (*this_it != *that_it) return false;
+ while (lhs_it != end()) {
+ if (*lhs_it != *rhs_it) return false;
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (*lhs_it != *rhs_it) { return false;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
