gavinchou commented on code in PR #33377:
URL: https://github.com/apache/doris/pull/33377#discussion_r1563620285


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/StorageVaultMgr.java:
##########
@@ -159,4 +162,31 @@ private void alterSyncVaultTask() {
             }
         });
     }
+
+    public void createS3Vault(StorageVault vault) throws DdlException {
+        S3StorageVault s3StorageVault = (S3StorageVault) vault;
+        Cloud.AlterObjStoreInfoRequest.Builder requestBuilder
+                = Cloud.AlterObjStoreInfoRequest.newBuilder();
+        
requestBuilder.setOp(Cloud.AlterObjStoreInfoRequest.Operation.ADD_S3_VAULT);
+        Cloud.ObjectStoreInfoPB.Builder objBuilder = 
S3Properties.getObjStoreInfoPB(vault.getCopiedProperties());
+        Cloud.StorageVaultPB.Builder alterObjVaultBuilder = 
Cloud.StorageVaultPB.newBuilder();
+        alterObjVaultBuilder.setName(s3StorageVault.getName());
+        alterObjVaultBuilder.setS3Obj(objBuilder.build());

Review Comment:
   ```suggestion
           alterObjVaultBuilder.setObjInfo(objBuilder.build());
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to