gavinchou commented on code in PR #33377:
URL: https://github.com/apache/doris/pull/33377#discussion_r1561463788
##########
be/src/cloud/cloud_meta_mgr.cpp:
##########
@@ -16,6 +16,7 @@
// under the License.
#include "cloud/cloud_meta_mgr.h"
+#include <bits/ranges_algo.h>
Review Comment:
is this a formal header?
##########
gensrc/proto/cloud.proto:
##########
@@ -191,15 +191,14 @@ message ObjectStoreInfoPB {
optional string user_id = 13;
optional EncryptionInfoPB encryption_info = 14;
optional bool sse_enabled = 15;
- optional string name = 16;
}
-// The legacy OObjectStoreInfoPBbjectStoreInfoPB is stored in instnaceinfopb
+// The legacy ObjectStoreInfoPB is stored in InstanceInfoPB
message StorageVaultPB {
optional string id = 1;
optional string name = 2;
optional HdfsVaultInfo hdfs_info = 3; // HdfsResource
- reserved 4; // reserved for S3.
+ optional ObjectStoreInfoPB s3_obj = 4;
Review Comment:
obj_info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
