This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch revert-7351-optimize_for_single_rowset
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
commit 13f20cf3f01ed3ff0425d29c8fe1140f97241506
Author: Mingyu Chen <morningman....@gmail.com>
AuthorDate: Fri Dec 17 14:23:25 2021 +0800
Revert "[improvement](reader) optimize for single rowset reading (#7351)"
This reverts commit 5745adb26cc87b7f9831a692286bc7cb565d31aa.
---
be/src/olap/tuple_reader.cpp | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/be/src/olap/tuple_reader.cpp b/be/src/olap/tuple_reader.cpp
index 430fa30..fa44e4a 100644
--- a/be/src/olap/tuple_reader.cpp
+++ b/be/src/olap/tuple_reader.cpp
@@ -79,16 +79,9 @@ OLAPStatus TupleReader::init(const ReaderParams&
read_params) {
auto status = _init_collect_iter(read_params, &rs_readers);
if (status != OLAP_SUCCESS) { return status; }
- // optimize for single rowset reading without do aggregation when reading
all columns,
- // and otherwise should use _agg_key_next_row for AGG_KEYS
if (_optimize_for_single_rowset(rs_readers)) {
- if(_tablet->keys_type() == AGG_KEYS && _return_columns.size() ==
_tablet->tablet_schema().num_columns()) {
- _next_row_func = &TupleReader::_direct_agg_key_next_row;
- } else if (_tablet->keys_type() == AGG_KEYS) {
- _next_row_func = &TupleReader::_agg_key_next_row;
- } else {
- _next_row_func = &TupleReader::_direct_next_row;
- }
+ _next_row_func = _tablet->keys_type() == AGG_KEYS ?
&TupleReader::_direct_agg_key_next_row
+ :
&TupleReader::_direct_next_row;
return OLAP_SUCCESS;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
