morrySnow commented on code in PR #33262:
URL: https://github.com/apache/doris/pull/33262#discussion_r1562090301


##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -2004,6 +2002,14 @@ public class Config extends ConfigBase {
                     + "the old load statement will be degraded."})
     public static boolean enable_nereids_load = false;
 
+    /**
+     * the plan cache num which can be reused for the next query
+     */
+    @ConfField(mutable = false, varType = VariableAnnotation.EXPERIMENTAL, 
description = {
+            "当前默认设置为 100,用来控制控制NereidsSqlCacheManager管理的sql cache数量。",
+            "Now default set to 100, this config is used to control the number 
of "
+                    + "sql cache managed by NereidsSqlCacheManager"})
+    public static int sql_cache_manage_num = 100;

Review Comment:
   could we use global variable to control it?



##########
fe/fe-core/src/main/java/org/apache/doris/nereids/CascadesContext.java:
##########
@@ -369,6 +373,10 @@ public void 
addMaterializationContext(MaterializationContext materializationCont
         this.materializationContexts.add(materializationContext);
     }
 
+    public void release() {

Review Comment:
   not used?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to