github-actions[bot] commented on code in PR #33579:
URL: https://github.com/apache/doris/pull/33579#discussion_r1562098692
##########
be/src/vec/exec/scan/scanner_scheduler.h:
##########
@@ -118,10 +118,20 @@ class SimplifiedScanScheduler {
_scan_thread_pool->wait();
}
- Status start() {
+ Status start(int max_thead_num, int min_thread_num) {
Review Comment:
warning: method 'start' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status start(int max_thead_num, int min_thread_num) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
