HappenLee commented on code in PR #33553: URL: https://github.com/apache/doris/pull/33553#discussion_r1562083853
########## be/src/vec/runtime/vdatetime_value.cpp: ########## @@ -2192,6 +2192,23 @@ bool DateV2Value<T>::from_date_str_base(const char* date_str, int len, int scale return false; } + // here maybe date changed because of rouding Review Comment: Add detail comment for the code. what case, why we need the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org