gavinchou commented on code in PR #33561:
URL: https://github.com/apache/doris/pull/33561#discussion_r1561120692
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/CreateStorageVaultStmt.java:
##########
@@ -72,6 +74,12 @@ public void
setStorageVaultType(StorageVault.StorageVaultType type) throws UserE
@Override
public void analyze(Analyzer analyzer) throws UserException {
+ if (!Config.isCloudMode()) {
+ throw new AnalysisException("Storage Vault is only supported for
cloud mode");
+ }
+ if (!((CloudEnv) Env.getCurrentEnv()).getEnableStorageVault()) {
Review Comment:
Add a comment: Some s3 back-ended storage does need to use storage vault.
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/CreateStorageVaultStmt.java:
##########
@@ -72,6 +74,12 @@ public void
setStorageVaultType(StorageVault.StorageVaultType type) throws UserE
@Override
public void analyze(Analyzer analyzer) throws UserException {
+ if (!Config.isCloudMode()) {
Review Comment:
```suggestion
if (Config.isNotCloudMode()) {
```
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/SetDefaultStorageVaultStmt.java:
##########
@@ -29,6 +35,17 @@ public String getStorageVaultName() {
return vaultName;
}
+ @Override
+ public void analyze(Analyzer analyzer) throws UserException {
+ if (!Config.isCloudMode()) {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
