mymeiyi commented on code in PR #33481:
URL: https://github.com/apache/doris/pull/33481#discussion_r1560368631
##########
be/src/exec/data_sink.cpp:
##########
@@ -169,7 +169,7 @@ Status DataSink::create_data_sink(ObjectPool* pool, const
TDataSink& thrift_sink
case TDataSinkType::GROUP_COMMIT_BLOCK_SINK: {
Status status = Status::OK();
DCHECK(thrift_sink.__isset.olap_table_sink);
- sink->reset(new vectorized::GroupCommitBlockSink(pool, row_desc,
output_exprs, &status));
+ sink->reset(new vectorized::GroupCommitBlockSink(pool, row_desc,
output_exprs));
RETURN_IF_ERROR(status);
Review Comment:
this is unused, status is not changed
##########
be/src/exec/data_sink.cpp:
##########
@@ -326,7 +326,7 @@ Status DataSink::create_data_sink(ObjectPool* pool, const
TDataSink& thrift_sink
case TDataSinkType::GROUP_COMMIT_BLOCK_SINK: {
Status status = Status::OK();
DCHECK(thrift_sink.__isset.olap_table_sink);
- sink->reset(new vectorized::GroupCommitBlockSink(pool, row_desc,
output_exprs, &status));
+ sink->reset(new vectorized::GroupCommitBlockSink(pool, row_desc,
output_exprs));
RETURN_IF_ERROR(status);
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
