github-actions[bot] commented on code in PR #33491: URL: https://github.com/apache/doris/pull/33491#discussion_r1559612678
########## be/src/pipeline/exec/aggregation_sink_operator_helper.h: ########## @@ -0,0 +1,274 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <cstdint> +#include <type_traits> + +#include "operator.h" +#include "pipeline/exec/aggregation_operator_helper.h" +#include "pipeline/pipeline_x/dependency.h" +#include "pipeline/pipeline_x/operator.h" +#include "runtime/block_spill_manager.h" +#include "runtime/exec_env.h" +#include "vec/exec/vaggregation_node.h" + +namespace doris { + +namespace pipeline { +template <typename Derived, typename OperatorX> +class AggSinkLocalStateHelper : public AggLocalStateHelper<Derived, OperatorX> { +public: + using AggLocalStateHelper<Derived, OperatorX>::_get_hash_table_size; + using AggLocalStateHelper<Derived, OperatorX>::_find_in_hash_table; + using AggLocalStateHelper<Derived, OperatorX>::_emplace_into_hash_table; + using AggLocalStateHelper<Derived, OperatorX>::_shared_state; + using AggLocalStateHelper<Derived, OperatorX>::_derived; + using AggLocalStateHelper<Derived, OperatorX>::_operator; + using AggLocalStateHelper<Derived, OperatorX>::_create_agg_status; + using AggLocalStateHelper<Derived, OperatorX>::_destroy_agg_status; + AggSinkLocalStateHelper(Derived * derived) : AggLocalStateHelper<Derived, OperatorX>(derived){} + ~AggSinkLocalStateHelper() = default; + Status _execute_without_key(vectorized::Block* block) { + DCHECK(_shared_state()->agg_data->without_key != nullptr); + SCOPED_TIMER(_derived()->_build_timer); + for (int i = 0; i < _shared_state()->aggregate_evaluators.size(); ++i) { + RETURN_IF_ERROR(_shared_state()->aggregate_evaluators[i]->execute_single_add( + block, + _shared_state()->agg_data->without_key + + _operator().offsets_of_aggregate_states[i], + _shared_state()->agg_arena_pool.get())); + } + return Status::OK(); + } + Status _execute_with_serialized_key(vectorized::Block* block) { + if (_derived()->_reach_limit) { + return _execute_with_serialized_key_helper<true>(block); + } else { + return _execute_with_serialized_key_helper<false>(block); + } + } + template <bool limit> + Status _execute_with_serialized_key_helper(vectorized::Block* block) { + SCOPED_TIMER(_derived()->_build_timer); + auto& _probe_expr_ctxs = _shared_state()->probe_expr_ctxs; + auto& _places = _derived()->_places; + auto& aggregate_evaluators = _shared_state()->aggregate_evaluators; + auto& agg_arena_pool = _shared_state()->agg_arena_pool; + DCHECK(!_probe_expr_ctxs.empty()); + + size_t key_size = _probe_expr_ctxs.size(); + vectorized::ColumnRawPtrs key_columns(key_size); + { + SCOPED_TIMER(_derived()->_expr_timer); + for (size_t i = 0; i < key_size; ++i) { + int result_column_id = -1; + RETURN_IF_ERROR(_probe_expr_ctxs[i]->execute(block, &result_column_id)); + block->get_by_position(result_column_id).column = + block->get_by_position(result_column_id) + .column->convert_to_full_column_if_const(); + key_columns[i] = block->get_by_position(result_column_id).column.get(); + } + } + + int rows = block->rows(); + if (_places.size() < rows) { + _places.resize(rows); + } + + if constexpr (limit) { + _find_in_hash_table(_places.data(), key_columns, rows); + + for (int i = 0; i < aggregate_evaluators.size(); ++i) { + RETURN_IF_ERROR(aggregate_evaluators[i]->execute_batch_add_selected( + block, _operator().offsets_of_aggregate_states[i], _places.data(), + agg_arena_pool.get())); + } + } else { + _emplace_into_hash_table(_places.data(), key_columns, rows); + + for (int i = 0; i < aggregate_evaluators.size(); ++i) { + RETURN_IF_ERROR(aggregate_evaluators[i]->execute_batch_add( + block, _operator().offsets_of_aggregate_states[i], _places.data(), + agg_arena_pool.get())); + } + + if (_derived()->_should_limit_output) { + _derived()->_reach_limit = _get_hash_table_size() >= _operator()._limit; + if (_derived()->_reach_limit && _operator()._can_short_circuit) { + _derived()->_dependency->set_ready_to_read(); + return Status::Error<ErrorCode::END_OF_FILE>(""); + } + } + } + + return Status::OK(); + } + // We should call this function only at 1st phase. + // 1st phase: is_merge=true, only have one SlotRef. + // 2nd phase: is_merge=false, maybe have multiple exprs. + int _get_slot_column_id(const vectorized::AggFnEvaluator* evaluator) { + auto ctxs = evaluator->input_exprs_ctxs(); + CHECK(ctxs.size() == 1 && ctxs[0]->root()->is_slot_ref()) + << "input_exprs_ctxs is invalid, input_exprs_ctx[0]=" + << ctxs[0]->root()->debug_string(); + return ((vectorized::VSlotRef*)ctxs[0]->root().get())->column_id(); + } + + Status _merge_without_key(vectorized::Block* block) { + SCOPED_TIMER(_derived()->_merge_timer); + auto& agg_data = _shared_state()->agg_data; + auto& aggregate_evaluators = _shared_state()->aggregate_evaluators; + auto& agg_arena_pool = _shared_state()->agg_arena_pool; + DCHECK(agg_data->without_key != nullptr); + for (int i = 0; i < aggregate_evaluators.size(); ++i) { + if (aggregate_evaluators[i]->is_merge()) { + int col_id = _get_slot_column_id(aggregate_evaluators[i]); + auto column = block->get_by_position(col_id).column; + if (column->is_nullable()) { + column = ((vectorized::ColumnNullable*)column.get())->get_nested_column_ptr(); + } + + SCOPED_TIMER(_derived()->_deserialize_data_timer); + aggregate_evaluators[i]->function()->deserialize_and_merge_from_column( + agg_data->without_key + _operator().offsets_of_aggregate_states[i], *column, + agg_arena_pool.get()); + } else { + RETURN_IF_ERROR(aggregate_evaluators[i]->execute_single_add( + block, agg_data->without_key + _operator().offsets_of_aggregate_states[i], + agg_arena_pool.get())); + } + } + return Status::OK(); + } + + Status _merge_with_serialized_key(vectorized::Block* block) { + if (_derived()->_reach_limit) { + return _merge_with_serialized_key_helper<true, false>(block); + } else { + return _merge_with_serialized_key_helper<false, false>(block); + } + } + + template <bool limit, bool for_spill> + Status _merge_with_serialized_key_helper(vectorized::Block* block) { Review Comment: warning: function '_merge_with_serialized_key_helper' exceeds recommended size/complexity thresholds [readability-function-size] ```cpp Status _merge_with_serialized_key_helper(vectorized::Block* block) { ^ ``` <details> <summary>Additional context</summary> **be/src/pipeline/exec/aggregation_sink_operator_helper.h:168:** 101 lines including whitespace and comments (threshold 80) ```cpp Status _merge_with_serialized_key_helper(vectorized::Block* block) { ^ ``` </details> ########## be/src/pipeline/exec/aggregation_sink_operator_helper.h: ########## @@ -0,0 +1,274 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <cstdint> +#include <type_traits> + +#include "operator.h" +#include "pipeline/exec/aggregation_operator_helper.h" +#include "pipeline/pipeline_x/dependency.h" +#include "pipeline/pipeline_x/operator.h" +#include "runtime/block_spill_manager.h" +#include "runtime/exec_env.h" +#include "vec/exec/vaggregation_node.h" + +namespace doris { + +namespace pipeline { +template <typename Derived, typename OperatorX> +class AggSinkLocalStateHelper : public AggLocalStateHelper<Derived, OperatorX> { +public: + using AggLocalStateHelper<Derived, OperatorX>::_get_hash_table_size; + using AggLocalStateHelper<Derived, OperatorX>::_find_in_hash_table; + using AggLocalStateHelper<Derived, OperatorX>::_emplace_into_hash_table; + using AggLocalStateHelper<Derived, OperatorX>::_shared_state; + using AggLocalStateHelper<Derived, OperatorX>::_derived; + using AggLocalStateHelper<Derived, OperatorX>::_operator; + using AggLocalStateHelper<Derived, OperatorX>::_create_agg_status; + using AggLocalStateHelper<Derived, OperatorX>::_destroy_agg_status; + AggSinkLocalStateHelper(Derived * derived) : AggLocalStateHelper<Derived, OperatorX>(derived){} + ~AggSinkLocalStateHelper() = default; + Status _execute_without_key(vectorized::Block* block) { + DCHECK(_shared_state()->agg_data->without_key != nullptr); + SCOPED_TIMER(_derived()->_build_timer); + for (int i = 0; i < _shared_state()->aggregate_evaluators.size(); ++i) { + RETURN_IF_ERROR(_shared_state()->aggregate_evaluators[i]->execute_single_add( + block, + _shared_state()->agg_data->without_key + + _operator().offsets_of_aggregate_states[i], + _shared_state()->agg_arena_pool.get())); + } + return Status::OK(); + } + Status _execute_with_serialized_key(vectorized::Block* block) { + if (_derived()->_reach_limit) { + return _execute_with_serialized_key_helper<true>(block); + } else { + return _execute_with_serialized_key_helper<false>(block); + } + } + template <bool limit> + Status _execute_with_serialized_key_helper(vectorized::Block* block) { + SCOPED_TIMER(_derived()->_build_timer); + auto& _probe_expr_ctxs = _shared_state()->probe_expr_ctxs; + auto& _places = _derived()->_places; + auto& aggregate_evaluators = _shared_state()->aggregate_evaluators; + auto& agg_arena_pool = _shared_state()->agg_arena_pool; + DCHECK(!_probe_expr_ctxs.empty()); + + size_t key_size = _probe_expr_ctxs.size(); + vectorized::ColumnRawPtrs key_columns(key_size); + { + SCOPED_TIMER(_derived()->_expr_timer); + for (size_t i = 0; i < key_size; ++i) { + int result_column_id = -1; + RETURN_IF_ERROR(_probe_expr_ctxs[i]->execute(block, &result_column_id)); + block->get_by_position(result_column_id).column = + block->get_by_position(result_column_id) + .column->convert_to_full_column_if_const(); + key_columns[i] = block->get_by_position(result_column_id).column.get(); + } + } + + int rows = block->rows(); + if (_places.size() < rows) { + _places.resize(rows); + } + + if constexpr (limit) { + _find_in_hash_table(_places.data(), key_columns, rows); + + for (int i = 0; i < aggregate_evaluators.size(); ++i) { + RETURN_IF_ERROR(aggregate_evaluators[i]->execute_batch_add_selected( + block, _operator().offsets_of_aggregate_states[i], _places.data(), + agg_arena_pool.get())); + } + } else { + _emplace_into_hash_table(_places.data(), key_columns, rows); + + for (int i = 0; i < aggregate_evaluators.size(); ++i) { + RETURN_IF_ERROR(aggregate_evaluators[i]->execute_batch_add( + block, _operator().offsets_of_aggregate_states[i], _places.data(), + agg_arena_pool.get())); + } + + if (_derived()->_should_limit_output) { + _derived()->_reach_limit = _get_hash_table_size() >= _operator()._limit; + if (_derived()->_reach_limit && _operator()._can_short_circuit) { + _derived()->_dependency->set_ready_to_read(); + return Status::Error<ErrorCode::END_OF_FILE>(""); + } + } + } + + return Status::OK(); + } + // We should call this function only at 1st phase. + // 1st phase: is_merge=true, only have one SlotRef. + // 2nd phase: is_merge=false, maybe have multiple exprs. + int _get_slot_column_id(const vectorized::AggFnEvaluator* evaluator) { + auto ctxs = evaluator->input_exprs_ctxs(); + CHECK(ctxs.size() == 1 && ctxs[0]->root()->is_slot_ref()) + << "input_exprs_ctxs is invalid, input_exprs_ctx[0]=" + << ctxs[0]->root()->debug_string(); + return ((vectorized::VSlotRef*)ctxs[0]->root().get())->column_id(); + } + + Status _merge_without_key(vectorized::Block* block) { + SCOPED_TIMER(_derived()->_merge_timer); + auto& agg_data = _shared_state()->agg_data; + auto& aggregate_evaluators = _shared_state()->aggregate_evaluators; + auto& agg_arena_pool = _shared_state()->agg_arena_pool; + DCHECK(agg_data->without_key != nullptr); + for (int i = 0; i < aggregate_evaluators.size(); ++i) { + if (aggregate_evaluators[i]->is_merge()) { + int col_id = _get_slot_column_id(aggregate_evaluators[i]); + auto column = block->get_by_position(col_id).column; + if (column->is_nullable()) { + column = ((vectorized::ColumnNullable*)column.get())->get_nested_column_ptr(); + } + + SCOPED_TIMER(_derived()->_deserialize_data_timer); + aggregate_evaluators[i]->function()->deserialize_and_merge_from_column( + agg_data->without_key + _operator().offsets_of_aggregate_states[i], *column, + agg_arena_pool.get()); + } else { + RETURN_IF_ERROR(aggregate_evaluators[i]->execute_single_add( + block, agg_data->without_key + _operator().offsets_of_aggregate_states[i], + agg_arena_pool.get())); + } + } + return Status::OK(); + } + + Status _merge_with_serialized_key(vectorized::Block* block) { + if (_derived()->_reach_limit) { + return _merge_with_serialized_key_helper<true, false>(block); + } else { + return _merge_with_serialized_key_helper<false, false>(block); + } + } + + template <bool limit, bool for_spill> + Status _merge_with_serialized_key_helper(vectorized::Block* block) { Review Comment: warning: function '_merge_with_serialized_key_helper' has cognitive complexity of 68 (threshold 50) [readability-function-cognitive-complexity] ```cpp Status _merge_with_serialized_key_helper(vectorized::Block* block) { ^ ``` <details> <summary>Additional context</summary> **be/src/pipeline/exec/aggregation_sink_operator_helper.h:179:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp for (size_t i = 0; i < key_size; ++i) { ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:180:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if constexpr (for_spill) { ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:182:** +1, nesting level increased to 2 ```cpp } else { ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:184:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp RETURN_IF_ERROR(probe_expr_ctxs[i]->execute(block, &result_column_id)); ^ ``` **be/src/common/status.h:541:** expanded from macro 'RETURN_IF_ERROR' ```cpp do { \ ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:184:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp RETURN_IF_ERROR(probe_expr_ctxs[i]->execute(block, &result_column_id)); ^ ``` **be/src/common/status.h:543:** expanded from macro 'RETURN_IF_ERROR' ```cpp if (UNLIKELY(!_status_.ok())) { \ ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:191:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (_places.size() < rows) { ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:195:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if constexpr (limit) { ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:198:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp for (int i = 0; i < aggregate_evaluators.size(); ++i) { ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:199:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp if (aggregate_evaluators[i]->is_merge()) { ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:202:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (column->is_nullable()) { ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:208:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (_deserialize_buffer.size() < buffer_size) { ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:220:** +1, nesting level increased to 3 ```cpp } else { ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:221:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp RETURN_IF_ERROR(aggregate_evaluators[i]->execute_batch_add_selected( ^ ``` **be/src/common/status.h:541:** expanded from macro 'RETURN_IF_ERROR' ```cpp do { \ ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:221:** +5, including nesting penalty of 4, nesting level increased to 5 ```cpp RETURN_IF_ERROR(aggregate_evaluators[i]->execute_batch_add_selected( ^ ``` **be/src/common/status.h:543:** expanded from macro 'RETURN_IF_ERROR' ```cpp if (UNLIKELY(!_status_.ok())) { \ ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:226:** +1, nesting level increased to 1 ```cpp } else { ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:229:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp for (int i = 0; i < aggregate_evaluators.size(); ++i) { ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:230:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp if (aggregate_evaluators[i]->is_merge() || for_spill) { ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:230:** +1 ```cpp if (aggregate_evaluators[i]->is_merge() || for_spill) { ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:232:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if constexpr (for_spill) { ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:234:** +1, nesting level increased to 4 ```cpp } else { ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:238:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (column->is_nullable()) { ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:244:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (_deserialize_buffer.size() < buffer_size) { ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:256:** +1, nesting level increased to 3 ```cpp } else { ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:257:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp RETURN_IF_ERROR(aggregate_evaluators[i]->execute_batch_add( ^ ``` **be/src/common/status.h:541:** expanded from macro 'RETURN_IF_ERROR' ```cpp do { \ ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:257:** +5, including nesting penalty of 4, nesting level increased to 5 ```cpp RETURN_IF_ERROR(aggregate_evaluators[i]->execute_batch_add( ^ ``` **be/src/common/status.h:543:** expanded from macro 'RETURN_IF_ERROR' ```cpp if (UNLIKELY(!_status_.ok())) { \ ^ ``` **be/src/pipeline/exec/aggregation_sink_operator_helper.h:263:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if (_derived()->_should_limit_output) { ^ ``` </details> ########## be/src/pipeline/exec/aggregation_source_operator_helper.h: ########## @@ -0,0 +1,45 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +#pragma once + +#include <stdint.h> Review Comment: warning: inclusion of deprecated C++ header 'stdint.h'; consider using 'cstdint' instead [modernize-deprecated-headers] ```suggestion #include <cstdint> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
