github-actions[bot] commented on code in PR #33414: URL: https://github.com/apache/doris/pull/33414#discussion_r1557421171
########## be/src/cloud/cloud_cumulative_compaction_policy.cpp: ########## @@ -213,4 +213,135 @@ int64_t CloudSizeBasedCumulativeCompactionPolicy::new_cumulative_point( : last_cumulative_point; } +int32_t CloudTimeSeriesCumulativeCompactionPolicy::pick_input_rowsets( Review Comment: warning: function 'pick_input_rowsets' exceeds recommended size/complexity thresholds [readability-function-size] ```cpp int32_t CloudTimeSeriesCumulativeCompactionPolicy::pick_input_rowsets( ^ ``` <details> <summary>Additional context</summary> **be/src/cloud/cloud_cumulative_compaction_policy.cpp:215:** 110 lines including whitespace and comments (threshold 80) ```cpp int32_t CloudTimeSeriesCumulativeCompactionPolicy::pick_input_rowsets( ^ ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org