morningman commented on code in PR #33003:
URL: https://github.com/apache/doris/pull/33003#discussion_r1557156615
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/LoadStmt.java:
##########
@@ -92,6 +94,15 @@ public class LoadStmt extends DdlStmt {
public static final String BOS_ACCESSKEY = "bos_accesskey";
public static final String BOS_SECRET_ACCESSKEY = "bos_secret_accesskey";
+ // for S3 load check
+ public static final String AWS_ENDPOINT = "AWS_ENDPOINT";
Review Comment:
This has been defined in S3Properties.java
##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -2685,6 +2685,16 @@ public static boolean isNotCloudMode() {
@ConfField(mutable = true, masterOnly = false)
public static String security_checker_class_name = "";
+
+ // the white list for the s3 load endpoint, if it is empty, no white list
will be set
+ // for example: s3_load_endpoint_white_list=a,b,c
+ @ConfField(mutable = true)
+ public static String[] s3_load_endpoint_white_list = {};
Review Comment:
Use same name as `jdbc_driver_secure_path`.
And does this config need to be mutable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
