github-actions[bot] commented on code in PR #33396:
URL: https://github.com/apache/doris/pull/33396#discussion_r1556175990
##########
be/src/runtime/memory/mem_tracker_limiter.cpp:
##########
@@ -144,6 +146,35 @@ MemTrackerLimiter::~MemTrackerLimiter() {
g_memtrackerlimiter_cnt << -1;
}
+void MemTrackerLimiter::add_address_sanitizers(void* buf, size_t size,
std::string stack_trace) {
Review Comment:
warning: method 'add_address_sanitizers' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void MemTrackerLimiter::add_address_sanitizers(void* buf, size_t
size, std::string stack_trace) {
```
##########
be/src/runtime/memory/mem_tracker_limiter.cpp:
##########
@@ -144,6 +146,35 @@
g_memtrackerlimiter_cnt << -1;
}
+void MemTrackerLimiter::add_address_sanitizers(void* buf, size_t size,
std::string stack_trace) {
+ {
+ std::lock_guard<std::mutex> l(_address_sanitizers_mtx);
+ auto it = _address_sanitizers.find(buf);
+ CHECK(it == _address_sanitizers.end());
+ AddressSanitizer as = {size, stack_trace};
+ _address_sanitizers.emplace(buf, as);
+ }
+}
+
+void MemTrackerLimiter::remove_address_sanitizers(void* buf) {
Review Comment:
warning: method 'remove_address_sanitizers' can be made static
[readability-convert-member-functions-to-static]
be/src/runtime/memory/mem_tracker_limiter.h:234:
```diff
- void remove_address_sanitizers(void* buf);
+ static void remove_address_sanitizers(void* buf);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
