github-actions[bot] commented on code in PR #33124:
URL: https://github.com/apache/doris/pull/33124#discussion_r1554948193
##########
be/src/vec/data_types/serde/data_type_ipv6_serde.h:
##########
@@ -53,6 +53,13 @@ class DataTypeIPv6SerDe : public DataTypeNumberSerDe<IPv6> {
FormatOptions& options) const override;
Status deserialize_one_cell_from_json(IColumn& column, Slice& slice,
const FormatOptions& options) const
override;
+ Status write_column_to_pb(const IColumn& column, PValues& result, int
start,
+ int end) const override {
Review Comment:
warning: method 'write_column_to_pb' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status write_column_to_pb(const IColumn& column, PValues& result,
int start,
int end) override {
```
##########
be/src/vec/data_types/serde/data_type_ipv4_serde.h:
##########
@@ -50,6 +50,13 @@ class DataTypeIPv4SerDe : public DataTypeNumberSerDe<IPv4> {
FormatOptions& options) const override;
Status deserialize_one_cell_from_json(IColumn& column, Slice& slice,
const FormatOptions& options) const
override;
+ Status write_column_to_pb(const IColumn& column, PValues& result, int
start,
+ int end) const override {
Review Comment:
warning: method 'write_column_to_pb' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status write_column_to_pb(const IColumn& column, PValues& result,
int start,
int end) override {
```
##########
be/src/vec/data_types/serde/data_type_ipv4_serde.h:
##########
@@ -50,6 +50,13 @@
FormatOptions& options) const override;
Status deserialize_one_cell_from_json(IColumn& column, Slice& slice,
const FormatOptions& options) const
override;
+ Status write_column_to_pb(const IColumn& column, PValues& result, int
start,
+ int end) const override {
+ return Status::NotSupported("write_column_to_pb with type " +
column.get_name());
+ }
+ Status read_column_from_pb(IColumn& column, const PValues& arg) const
override {
Review Comment:
warning: method 'read_column_from_pb' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status read_column_from_pb(IColumn& column, const PValues& arg)
override {
```
##########
be/src/vec/data_types/serde/data_type_ipv6_serde.h:
##########
@@ -53,6 +53,13 @@
FormatOptions& options) const override;
Status deserialize_one_cell_from_json(IColumn& column, Slice& slice,
const FormatOptions& options) const
override;
+ Status write_column_to_pb(const IColumn& column, PValues& result, int
start,
+ int end) const override {
+ return Status::NotSupported("write_column_to_pb with type " +
column.get_name());
+ }
+ Status read_column_from_pb(IColumn& column, const PValues& arg) const
override {
Review Comment:
warning: method 'read_column_from_pb' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status read_column_from_pb(IColumn& column, const PValues& arg)
override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
