github-actions[bot] commented on code in PR #33291:
URL: https://github.com/apache/doris/pull/33291#discussion_r1554836376
##########
be/src/pipeline/exec/partitioned_hash_join_sink_operator.cpp:
##########
@@ -55,10 +57,69 @@ Status
PartitionedHashJoinSinkLocalState::close(RuntimeState* state, Status exec
return PipelineXSpillSinkLocalState::close(state, exec_status);
}
+size_t PartitionedHashJoinSinkLocalState::revocable_mem_size(RuntimeState*
state) const {
Review Comment:
warning: method 'revocable_mem_size' can be made static
[readability-convert-member-functions-to-static]
```suggestion
size_t PartitionedHashJoinSinkLocalState::revocable_mem_size(RuntimeState*
state) {
```
be/src/pipeline/exec/partitioned_hash_join_sink_operator.h:50:
```diff
- size_t revocable_mem_size(RuntimeState* state) const;
+ static size_t revocable_mem_size(RuntimeState* state) ;
```
##########
be/src/pipeline/exec/partitioned_hash_join_sink_operator.cpp:
##########
@@ -183,10 +283,53 @@
}
Status PartitionedHashJoinSinkOperatorX::prepare(RuntimeState* state) {
- return Status::OK();
+ RETURN_IF_ERROR(_inner_sink_operator->set_child(_child_x));
+ return _inner_sink_operator->prepare(state);
}
Status PartitionedHashJoinSinkOperatorX::open(RuntimeState* state) {
+ return _inner_sink_operator->open(state);
+}
+
+Status
PartitionedHashJoinSinkOperatorX::_setup_internal_operator(RuntimeState* state)
{
Review Comment:
warning: method '_setup_internal_operator' can be made static
[readability-convert-member-functions-to-static]
be/src/pipeline/exec/partitioned_hash_join_sink_operator.h:138:
```diff
- Status _setup_internal_operator(RuntimeState* state);
+ static Status _setup_internal_operator(RuntimeState* state);
```
##########
be/src/pipeline/exec/partitioned_hash_join_sink_operator.cpp:
##########
@@ -124,14 +185,53 @@
return Status::OK();
}
+Status PartitionedHashJoinSinkLocalState::_partition_block(RuntimeState* state,
Review Comment:
warning: method '_partition_block' can be made static
[readability-convert-member-functions-to-static]
be/src/pipeline/exec/partitioned_hash_join_sink_operator.h:59:
```diff
- Status _partition_block(RuntimeState* state, vectorized::Block*
in_block, size_t begin,
+ static Status _partition_block(RuntimeState* state, vectorized::Block*
in_block, size_t begin,
```
##########
be/src/pipeline/exec/partitioned_hash_join_probe_operator.cpp:
##########
@@ -570,6 +563,15 @@ Status
PartitionedHashJoinProbeOperatorX::push(RuntimeState* state, vectorized::
return Status::OK();
}
+Status
PartitionedHashJoinProbeOperatorX::_setup_internal_operator_for_non_spill(
Review Comment:
warning: method '_setup_internal_operator_for_non_spill' can be made static
[readability-convert-member-functions-to-static]
be/src/pipeline/exec/partitioned_hash_join_probe_operator.h:197:
```diff
- [[nodiscard]] Status _setup_internal_operator_for_non_spill(
+ [[nodiscard]] static Status _setup_internal_operator_for_non_spill(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
