github-actions[bot] commented on code in PR #33295:
URL: https://github.com/apache/doris/pull/33295#discussion_r1554820380
##########
be/src/vec/columns/column_nullable.h:
##########
@@ -82,7 +82,9 @@ class ColumnNullable final : public COWHelper<IColumn,
ColumnNullable> {
}
MutableColumnPtr get_shrinked_column() override;
+ bool could_shrinked_column() override;
bool is_variable_length() const override { return
nested_column->is_variable_length(); }
+
Review Comment:
warning: method 'get_family_name' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static const char* get_family_name() override { return "Nullable"; }
```
##########
be/src/vec/columns/column_struct.cpp:
##########
@@ -295,13 +295,22 @@ ColumnPtr ColumnStruct::replicate(const Offsets& offsets)
const {
return ColumnStruct::create(new_columns);
}
+bool ColumnStruct::could_shrinked_column() {
Review Comment:
warning: method 'could_shrinked_column' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/columns/column_struct.h:158:
```diff
- bool could_shrinked_column() override;
+ static bool could_shrinked_column() override;
```
##########
be/src/vec/columns/column_string.h:
##########
@@ -120,6 +120,7 @@ class ColumnString final : public COWHelper<IColumn,
ColumnString> {
MutableColumnPtr clone_resized(size_t to_size) const override;
MutableColumnPtr get_shrinked_column() override;
+ bool could_shrinked_column() override { return true; }
Review Comment:
warning: method 'could_shrinked_column' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static bool could_shrinked_column() override { return true; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
