yiguolei commented on code in PR #33282:
URL: https://github.com/apache/doris/pull/33282#discussion_r1554792810
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -3206,14 +3205,14 @@ public void readFromJson(String json) throws
IOException {
Review Comment:
我觉得这么写太迷惑了，不如直接在加一个新的annotation，比如叫做converter="convertToFromBoolean"
然后在session variable 里定义一下。 这样就相当于只对auto commit 这一个变量做一下convert。
否则累死3208行，这是大面上都在做convert，未来很难扩展。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
