github-actions[bot] commented on code in PR #33243:
URL: https://github.com/apache/doris/pull/33243#discussion_r1550030163
##########
be/src/vec/functions/function_string.h:
##########
@@ -3852,4 +3852,61 @@ class FunctionIntToChar : public IFunction {
#endif
}
};
+
+class FunctionStrInsert : public IFunction {
+public:
+ static constexpr auto name = "str_insert";
+ static FunctionPtr create() { return
std::make_shared<FunctionStrInsert>(); }
+ String get_name() const override { return name; }
+ size_t get_number_of_arguments() const override { return 4; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+ return std::make_shared<DataTypeString>();
Review Comment:
warning: method 'get_return_type_impl' can be made static
[readability-convert-member-functions-to-static]
```suggestion
de { return 4; }
consstatic t override {
```
##########
be/src/vec/functions/function_string.h:
##########
@@ -3852,4 +3852,61 @@
#endif
}
};
+
+class FunctionStrInsert : public IFunction {
+public:
+ static constexpr auto name = "str_insert";
+ static FunctionPtr create() { return
std::make_shared<FunctionStrInsert>(); }
+ String get_name() const override { return name; }
+ size_t get_number_of_arguments() const override { return 4; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+ return std::make_shared<DataTypeString>();
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
Review Comment:
warning: method 'execute_impl' can be made static
[readability-convert-member-functions-to-static]
```suggestion
String>();static
```
be/src/vec/functions/function_string.h:3868:
```diff
- const override {
+ override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
