yiguolei commented on code in PR #33235:
URL: https://github.com/apache/doris/pull/33235#discussion_r1549586078
##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -1482,16 +1482,23 @@ public void cancel() {
}
return;
}
- Coordinator coordRef = coord;
- if (coordRef != null) {
- coordRef.cancel();
- }
if (mysqlLoadId != null) {
Env.getCurrentEnv().getLoadManager().getMysqlLoadManager().cancelMySqlLoad(mysqlLoadId);
}
if (parsedStmt instanceof AnalyzeTblStmt || parsedStmt instanceof
AnalyzeDBStmt) {
Env.getCurrentEnv().getAnalysisManager().cancelSyncTask(context);
}
+
+ Coordinator coordRef = coord;
+ if (coordRef != null) {
+ coordRef.cancel();
+ } else {
+ // force cancel, for scenerios when above strategies does not
work, like sql error in analyze period
+ if (context != null) {
+ context.cleanup();
Review Comment:
The modification is very dangerouse. If you cleanup the context, we do not
know the actual value in context and the analyzer may use it. And send some
illegal plan to BE and BE may core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
