github-actions[bot] commented on code in PR #33229:
URL: https://github.com/apache/doris/pull/33229#discussion_r1549400793
##########
be/src/pipeline/pipeline_x/dependency.cpp:
##########
@@ -267,11 +267,21 @@ void AggSpillPartition::close() {
}
void PartitionedAggSharedState::close() {
+ if (is_closed) {
+ return;
+ }
+ is_closed = true;
for (auto partition : spill_partitions) {
partition->close();
}
+ spill_partitions.clear();
}
-void SpillSortSharedState::clear() {
+
+void SpillSortSharedState::close() {
Review Comment:
warning: method 'close' can be made static
[readability-convert-member-functions-to-static]
be/src/pipeline/pipeline_x/dependency.h:514:
```diff
- void close();
+ static void close();
```
##########
be/src/vec/spill/spill_stream.cpp:
##########
@@ -103,9 +113,9 @@ Status SpillStream::wait_spill() {
return Status::OK();
}
-Status SpillStream::spill_block(const Block& block, bool eof) {
+Status SpillStream::spill_block(RuntimeState* state, const Block& block, bool
eof) {
Review Comment:
warning: method 'spill_block' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/spill/spill_stream.h:55:
```diff
- Status spill_block(RuntimeState* state, const Block& block, bool eof);
+ static Status spill_block(RuntimeState* state, const Block& block,
bool eof);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
