github-actions[bot] commented on code in PR #33015:
URL: https://github.com/apache/doris/pull/33015#discussion_r1547114067
##########
be/src/service/backend_service.cpp:
##########
@@ -1129,4 +1133,51 @@ void
BaseBackendService::warm_up_tablets(TWarmUpTabletsResponse& response,
response.__set_status(Status::NotSupported("warm_up_tablets is not
implemented").to_thrift());
}
+void BaseBackendService::get_realtime_query_exec_status(
Review Comment:
warning: method 'get_realtime_query_exec_status' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void BaseBackendService::get_realtime_query_exec_status(
```
##########
be/src/runtime/runtime_query_statistics_mgr.h:
##########
@@ -75,9 +82,65 @@ class RuntimeQueryStatiticsMgr {
// used for backend_active_tasks
void get_active_be_tasks_block(vectorized::Block* block);
+ void start_report_thread();
+ void report_query_profiles_thread();
+ void force_report_profile();
+ void stop_report_thread();
+
+ void submit_report_status_task(const TUniqueId& q_id, const
TNetworkAddress& coor_addr,
+ int32 f_id, const TUniqueId& i_id, int
be_num, bool done,
+ Status exec_status);
+
+ void register_instance_profile(const TUniqueId& query_id, const
TNetworkAddress& coor_addr,
+ const TUniqueId& instance_id,
+ std::shared_ptr<TRuntimeProfileTree>
i_profile);
+
+ void register_fragment_profile_x(const TUniqueId& query_id, const
TNetworkAddress& const_addr,
+ int32_t fragment_id,
+
std::vector<std::shared_ptr<TRuntimeProfileTree>> p_profiles);
+ using CoorAddrWithFragmentProfileMap =
+ std::tuple<TNetworkAddress,
+ std::unordered_map<int,
std::vector<std::shared_ptr<TRuntimeProfileTree>>>>;
+
+ using CoorAddrWithInstanceProfileMap =
+ std::tuple<TNetworkAddress,
+ std::unordered_map<TUniqueId,
std::shared_ptr<TRuntimeProfileTree>>>;
+
+ static TReportExecStatusParams create_report_exec_status_params(
+ const TUniqueId& q_id, int32 f_id,
+ const std::vector<std::shared_ptr<TRuntimeProfileTree>>&
f_profile);
+
+ static void report_query_profile(
+ const TUniqueId&, const TNetworkAddress&,
+ const std::unordered_map<int,
std::vector<std::shared_ptr<TRuntimeProfileTree>>>&);
Review Comment:
warning: parameter 3 is const-qualified in the function declaration;
const-qualification of parameters only has an effect in function definitions
[readability-avoid-const-params-in-decls]
```suggestion
std::unordered_map<int,
std::vector<std::shared_ptr<TRuntimeProfileTree>>>&);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
